Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flatpak build failing due to too large icons #7875

Merged

Conversation

achim-k
Copy link
Contributor

@achim-k achim-k commented Nov 12, 2023

Fixes #7854

When building for Flatpak, electron-builder (or rather app-builder-bin) creates a set of icons from the Mac icns file which includes a 1024x1024 sized icon. According to the Flatpak spec however, icons must not be larger than 512px. This is the reason why the Flatpak build fails e.g. with the following error:

Copy link

changeset-bot bot commented Nov 12, 2023

🦋 Changeset detected

Latest commit: b3f241d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 12, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit b3f241d
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65518d4feee9dc0008635f98
😎 Deploy Preview https://deploy-preview-7875--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta changed the title Fix flatpak build failing due to too large icons fix: flatpak build failing due to too large icons Nov 13, 2023
@mmaietta mmaietta merged commit 9883ab6 into electron-userland:master Nov 13, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building Flatpak fails with Image too large (1024x1024). Max. size 512x512
2 participants