feat(snap): Use core20 as default base for snap target
#7902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core18 is quite old base nowadays and it's better to use a newer base to have more updated desktop libraries around to have better toolkit integration and wayland support. People relying on older bases can always explicitly use core18 when upgrading electron-builder.
🦋 Changeset detectedLatest commit: 3a865b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3v1n0
changed the title
|
|
mmaietta
changed the title
core20 as default base for snap target
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core18 is quite old base nowadays and it's better to use a newer base to have more updated desktop libraries around to have better toolkit integration and wayland support.
People relying on older bases can always explicitly use core18 when upgrading electron-builder.
It would be even better to actually switch to
core22that is now stable enough, but let me know what you think about or if you'd prefer to rely on more conservative approach.