Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(archive): skip archive when up to date #7971

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

OrbitZore
Copy link
Contributor

I discovered that when I use the --dir option and --prepackaged -c to build different installers with various NSIS configurations, electron-builder repeatedly compresses the unpacked directory with 7zip. This process is time-consuming - in my case, it takes about 5 minutes to build one installer. To improve this, I implemented a modification time (mtime) check before the compression step, which is a common practice in build systems like GNU make. This change reduces the build time to 15 seconds per installer, making this use case more practical. It should not break the API.

Copy link

changeset-bot bot commented Jan 7, 2024

🦋 Changeset detected

Latest commit: d2be46b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit d2be46b
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/659c7d163c58be0008713d04
😎 Deploy Preview https://deploy-preview-7971--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 8803852 into electron-userland:master Jan 9, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
@LoveLuanQi1202
Copy link

Hi OrbitZore,

Thank you for your work on this project. I wanted to report an issue I encountered while using Electron Builder.

In my project, I have configured artifactName as "name.${ext}". When packaging for Mac with the universal architecture, the process first generates an arm zip and then creates a universal zip, which overwrites the original arm zip. However, the skipped archiving step prevents this from happening.

This issue causes complications in my packaging process, and I believe it might be affecting others as well.

Thank you for your attention to this matter.

@OrbitZore
Copy link
Contributor Author

Hi OrbitZore,

Thank you for your work on this project. I wanted to report an issue I encountered while using Electron Builder.

In my project, I have configured artifactName as "name.${ext}". When packaging for Mac with the universal architecture, the process first generates an arm zip and then creates a universal zip, which overwrites the original arm zip. However, the skipped archiving step prevents this from happening.

This issue causes complications in my packaging process, and I believe it might be affecting others as well.

Thank you for your attention to this matter.

Perhaps we should consider assigning distinct names for the arm zip and universal zip files.The overwriten is ridiculous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants