-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(archive): skip archive when up to date #7971
Conversation
🦋 Changeset detectedLatest commit: d2be46b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi OrbitZore, Thank you for your work on this project. I wanted to report an issue I encountered while using Electron Builder. In my project, I have configured artifactName as "name.${ext}". When packaging for Mac with the universal architecture, the process first generates an arm zip and then creates a universal zip, which overwrites the original arm zip. However, the skipped archiving step prevents this from happening. This issue causes complications in my packaging process, and I believe it might be affecting others as well. Thank you for your attention to this matter. |
Perhaps we should consider assigning distinct names for the arm zip and universal zip files.The overwriten is ridiculous. |
I discovered that when I use the
--dir
option and--prepackaged -c
to build different installers with various NSIS configurations, electron-builder repeatedly compresses the unpacked directory with 7zip. This process is time-consuming - in my case, it takes about 5 minutes to build one installer. To improve this, I implemented a modification time (mtime) check before the compression step, which is a common practice in build systems like GNU make. This change reduces the build time to 15 seconds per installer, making this use case more practical. It should not break the API.