Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): only skip notarization step when notarize is explicitly false #8065

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

mmaietta
Copy link
Collaborator

Fixes: #8040

Copy link

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: 2387fc5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 2387fc5
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65d4df904d779a0008d4bb26
😎 Deploy Preview https://deploy-preview-8065--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 5681777 into master Feb 20, 2024
15 checks passed
@mmaietta mmaietta deleted the fix/notarize-true branch February 20, 2024 18:50
@defunctzombie
Copy link

@mmaietta this change broke our build/packaging process. For some context: we use a different notarization script and had set the environment variables for notarization. Prior to this change, leaving notarize undefined but having the variables set did not run the notarization logic in electron-builder. The new logic here requires that you explicitly set notarize to false to disable the logic if the variables are present.

I can see it working either way but wanted to call out that the change here changes the previous semantics of what would be considered disabling notarization from being undefined or false to now having to be explicitly false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notarize: true has no effect with apple API key
2 participants