Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disableSanityCheckPackage to asar to allow custom electron fork asar integrity implementations #8123

Merged

Conversation

beyondkmp
Copy link
Collaborator

fix #8122

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: b3af362

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit b3af362
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65ef277513636200082633f9
😎 Deploy Preview https://deploy-preview-8123--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator

Hot dam @beyondkmp, you're on a roll! 🙂 Will update this PR with changeset and docs, then will get this merged in

@mmaietta mmaietta changed the title feat: add disableSanityCheckPackage feat: add disableSanityCheckPackage to asar to allow custom electron fork asar integrity implementations Mar 11, 2024
@mmaietta mmaietta merged commit 031d7d5 into electron-userland:master Mar 11, 2024
14 checks passed
@beyondkmp
Copy link
Collaborator Author

@mmaietta In window, there's an error when running pnpm generate-all, so I did not update the config yesterday.
image (7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable sanityCheckPackage in the doPack step
2 participants