Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace SYSTEMROOT with SYSDIR #8133

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

beyondkmp
Copy link
Collaborator

fix #8131

Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: c5280eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit c5280eb
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65f260707b22a6000810cf0f
😎 Deploy Preview https://deploy-preview-8133--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beyondkmp beyondkmp changed the title fix: add define for SYSTEMROOT fix: define %SYSTEMROOT% as a constant Mar 13, 2024
@mmaietta
Copy link
Collaborator

Interesting, nice catch!

Looks like a test is failing with the changes though when compiling via docker TEST_FILES=protonTest pnpm test-linux

FAIL  src/protonTest.ts (40.249 s)
  ✓ linux (7412 ms)
  ✕ win (18135 ms)
  ✕ win ia32 (13049 ms)

    Processing script file: "<stdin>" (UTF8)
    warning 6000: unknown variable/constant "%SYSTEMROOT%\System32\cmd.exe"" detected, ignoring (macro:FIND_PROCESS:5)

@beyondkmp
Copy link
Collaborator Author

beyondkmp commented Mar 14, 2024

@mmaietta Fixed.

@beyondkmp beyondkmp changed the title fix: define %SYSTEMROOT% as a constant fix: replace SYSTEMROOT with SYSDIR Mar 14, 2024
@mmaietta mmaietta merged commit 44b0446 into electron-userland:master Mar 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants