feat: Add Support for a separate Github release token to the auto-update token #8173
Conversation
…token Reference: electron-userland#5688 - Discussion about keeping two separate tokens; one for publishing to Github releases and the other used by the app to make requests for auto-update updates. Now you can set a release token that has write permissions to publish your release. The release token will be used instead of a GH_TOKEN || GITHUB_TOKEN ONLY during publishing. The Github token defined via the Github options or environment variable will still be used as normal. mac: ``` export GITHUB_RELEASE_TOKEN=<my token> ``` I used the Contents permission for a New fine-grained personal access token with "Read and write". "Read-only" for the usual app-update token. So even if the app-update token is inside your app-update.yml its only read-only, yay! (Mac: you can find the app-update.yml by right-click > Show Package Contents > Contents > Resources)
🦋 Changeset detectedLatest commit: 08d986e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AndrewEQ
changed the title
|
Love this idea, thank you for opening a PR! Do we need to update the docs anywhere for this change? Looks like this may need to be updated to include your new logic/description |
Cool, added a note to the publish docs 👍 |
Reference: #5688 - Discussion about keeping two separate tokens; one for publishing to Github releases and the other used by the app to make requests for auto-update updates.
Now you can set a release token that has write permissions to publish your release.
The release token will be used instead of a GH_TOKEN || GITHUB_TOKEN ONLY during publishing.
The Github token defined via the Github options or environment variable will still be used as normal.
mac:
export GITHUB_RELEASE_TOKEN=<my token>I used the Contents permission for a New fine-grained personal access token with "Read and write". "Read-only" for the usual app-update token.
So even if the app-update token is inside your app-update.yml its only read-only, yay! (Mac: you can find the app-update.yml by right-click > Show Package Contents > Contents > Resources)