refactor: builder-util-runtime, separate newError to eliminate circular dependency #8251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After importing
electron-updater
, Rollup would log this warning:This is because builder-util-runtime/src/index.ts exports from many other modules, and several of those modules import from it with
import { newError } from './index
.This PR removes the circular dependency by extracting
newError
toerror.ts
and importing it from there.