-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: @electron/remote wrongly into Windows app.asar #8254
Conversation
🦋 Changeset detectedLatest commit: a97efec The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mmaietta I found a new bug. If a node module is aliased, it will cause the corresponding package in the ASAR file to be incorrect. Please help revivew: develar/app-builder#119 |
@mmaietta It seems like the CI has a cache, comparing with the previous snapshot. Often, the first run fails, and then it succeeds on a rerun without any changes. I haven't found the root cause yet. |
@beyondkmp thank you! Reran the CI and it all passes, I'm not sure re: the caching issue but it is indeed leading to a flaky CI (which needs fixing for sure) Does this PR depend on a release of the app-builder-bin changes as well? |
There's no interdependency. |
@mmaietta Please help rerun the failed job. |
Fix #8252