Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @electron/remote wrongly into Windows app.asar #8254

Merged
merged 11 commits into from
Jun 23, 2024

Conversation

beyondkmp
Copy link
Collaborator

@beyondkmp beyondkmp commented Jun 9, 2024

Fix #8252

Copy link

changeset-bot bot commented Jun 9, 2024

🦋 Changeset detected

Latest commit: a97efec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit a97efec
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/666e446626692a00084315e3
😎 Deploy Preview https://deploy-preview-8254--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beyondkmp beyondkmp changed the title Fix: Windows asar fix: @electron/remote wrongly into Windows app.asar Jun 9, 2024
@beyondkmp
Copy link
Collaborator Author

beyondkmp commented Jun 11, 2024

@mmaietta I found a new bug. If a node module is aliased, it will cause the corresponding package in the ASAR file to be incorrect. Please help revivew: develar/app-builder#119

@beyondkmp
Copy link
Collaborator Author

@mmaietta It seems like the CI has a cache, comparing with the previous snapshot. Often, the first run fails, and then it succeeds on a rerun without any changes. I haven't found the root cause yet.

@mmaietta
Copy link
Collaborator

@beyondkmp thank you! Reran the CI and it all passes, I'm not sure re: the caching issue but it is indeed leading to a flaky CI (which needs fixing for sure)

Does this PR depend on a release of the app-builder-bin changes as well?

@beyondkmp
Copy link
Collaborator Author

beyondkmp commented Jun 14, 2024

There's no interdependency.

@beyondkmp
Copy link
Collaborator Author

@mmaietta Please help rerun the failed job.

@mmaietta mmaietta merged commit dc5d7c8 into electron-userland:master Jun 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

25.0.0-alpha.9 bundles @electron/remote wrongly into Windows app.asar
2 participants