Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add global download promise to limit concurrent downloads to 1 #8378

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

s77rt
Copy link
Contributor

@s77rt s77rt commented Jul 25, 2024

Calling autoUpdater.checkForUpdates() twice initiates two download processes that conflict and results in update failure. This PR adds a global download promise limiting the download processes to 1.

Fixes: #7063

Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: 6881e6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 6881e6d
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66a269aed5637200083d1d31
😎 Deploy Preview https://deploy-preview-8378--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@s77rt s77rt changed the title Add global download promise to allow one concurrent download at most fix: Add global download promise to limit concurrent downloads to 1 Jul 25, 2024
@mmaietta mmaietta merged commit c8fe146 into electron-userland:master Jul 25, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
@s77rt
Copy link
Contributor Author

s77rt commented Jul 25, 2024

@mmaietta @beyondkmp Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-update fails with ENOENT: no such file or directory, rename
3 participants