-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct native dependency tree mismatch in app-builder rebuild #8450
Conversation
🦋 Changeset detectedLatest commit: 831a81e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@beyondkmp can you take a look at this when you have a chance? This PR is proposing conditionally applying the |
@leey0818 do you have a github issue that this is fixing? Or can you provide a minimal repro repo as to what the issue is originally? I'd like to create a unit test for this if possible |
@mmaietta This PR might be able to fix the issue(#8426 (comment)) I have a question: will the legacy configuration for nativeRebuilder be deprecated in the future, or will it be retained permanently?
|
Probably retained for quite some time, but eventually deprecated and finally removed. Just want to make it easy to debug any issues that arise between app-builder-bin migration to electron-rebuild. electron-builder v25 still doesn't have broad adoption as |
LGTM |
Fixed #8459 |
This PR fixes the mismatch in the dependency tree structure provided by the rebuild-node-modules command in the app-builder binary.