Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct native dependency tree mismatch in app-builder rebuild #8450

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

leey0818
Copy link
Contributor

@leey0818 leey0818 commented Sep 5, 2024

This PR fixes the mismatch in the dependency tree structure provided by the rebuild-node-modules command in the app-builder binary.

Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: 831a81e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
electron-builder Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 831a81e
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66d9d663408ba70008a3f060
😎 Deploy Preview https://deploy-preview-8450--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator

mmaietta commented Sep 8, 2024

@beyondkmp can you take a look at this when you have a chance? This PR is proposing conditionally applying the --flatten flag.

@mmaietta
Copy link
Collaborator

mmaietta commented Sep 8, 2024

@leey0818 do you have a github issue that this is fixing? Or can you provide a minimal repro repo as to what the issue is originally? I'd like to create a unit test for this if possible

@beyondkmp
Copy link
Collaborator

beyondkmp commented Sep 9, 2024

@mmaietta This PR might be able to fix the issue(#8426 (comment))

I have a question: will the legacy configuration for nativeRebuilder be deprecated in the future, or will it be retained permanently?

nativeRebuilder = sequential “legacy” | “sequential” | “parallel” | “undefined” - Use legacy app-builder binary for installing native dependencies, or @electron/rebuild in sequential or parallel compilation modes.

@mmaietta
Copy link
Collaborator

mmaietta commented Sep 9, 2024

I have a question: will the legacy configuration for nativeRebuilder be deprecated in the future, or will it be retained permanently?

Probably retained for quite some time, but eventually deprecated and finally removed. Just want to make it easy to debug any issues that arise between app-builder-bin migration to electron-rebuild. electron-builder v25 still doesn't have broad adoption as latest tag

@leey0818
Copy link
Contributor Author

@mmaietta I have created a GitHub issue (#8459).

Using the legacy option to utilize pre-built native dependencies in a cross-platform build. It seems that @electron/rebuild does not yet support cross-platform builds.

@beyondkmp
Copy link
Collaborator

LGTM

@mmaietta mmaietta merged commit 55671bd into electron-userland:master Sep 13, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
@leey0818
Copy link
Contributor Author

Fixed #8459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants