Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appx): utilize applicationId verbatim when provided #8502

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Sep 19, 2024

Force using applicationId if provided before falling back to identityName or app name
Fixes: #8479

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: ca5488e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit ca5488e
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66eb6faebc1991000861e65c
😎 Deploy Preview https://deploy-preview-8502--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 4b2f693 into master Sep 19, 2024
15 checks passed
@mmaietta mmaietta deleted the fix-applicationId branch September 19, 2024 00:57
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
xyloflake pushed a commit to xyloflake/electron-builder that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appx build failure because of identityName
1 participant