Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Path does not end with the package name #8560

Merged
merged 6 commits into from
Oct 6, 2024

Conversation

beyondkmp
Copy link
Collaborator

@beyondkmp beyondkmp commented Oct 5, 2024

fix #8558

The @isaacs/cliui package depends on string-width-cjs@4.2.3, but the package that's actually downloaded is string-width@4.2.3. The name in the path doesn't match the original name, which is causing an error.
Fix solution: Truncate based on scope depth, not by name.

"string-width-cjs": {
          "from": "string-width",
          "version": "4.2.3",
          "resolved": "https://registry.npmjs.org/string-width/-/string-width-4.2.3.tgz",
          "description": "Get the visual width of a string - the number of columns required to display it",
          "license": "MIT",
          "author": {
            "name": "Sindre Sorhus",
            "email": "sindresorhus@gmail.com",
            "url": "sindresorhus.com"
          },
          "homepage": "https://github.com/sindresorhus/string-width#readme",
          "repository": "git+https://github.com/sindresorhus/string-width.git",
          "path": "/Users/beyondkmp/Code/deepFocus/node_modules/.pnpm/string-width@4.2.3/node_modules/string-width",
}                 
                             

Copy link

changeset-bot bot commented Oct 5, 2024

🦋 Changeset detected

Latest commit: 3c8f924

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 3c8f924
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6700ca135b356a00088a810c
😎 Deploy Preview https://deploy-preview-8560--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beyondkmp beyondkmp merged commit 4ff778e into electron-userland:master Oct 6, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Oct 6, 2024
@beyondkmp beyondkmp deleted the realSource branch October 6, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path does not end with the package name
2 participants