fix(win): add mandatory publisherName field to Azure Trusted Signing
#8650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actored signing manager to have common interface
🦋 Changeset detectedLatest commit: 080fd40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for car-park-attendant-cleat-11576 failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support signature verification during auto-update flow with Azure Trusted Signing, a
publisherNamefield must be added (mirrors that of signtool, except that one is optional).Previously, the
publisherNamecould be read from local signing certificate automatically, but we want to avoid having both signtool and Azure Trusted Signing accidentally being used at the same time as Azure Trusted Signing doesn't have a publisher name accessible at the time of app-update.yml being created. (app-update.yml creation is duringafterPackstage, as opposed toafterSign)