Skip to content

Conversation

@nathanlesage
Copy link
Contributor

Hej! As announced in my recent issue, here are my suggestions to improve the Azure Trusted Signing documentation. I tried to find a balance between "not explaining everything" and ensuring that people understand the very confusing naming conventions Microsoft uses in its documentation (such as "Service Principal" versus "App Registration"). I believe that the way I tried to condense it hopefully makes it easier understandable for users to get started.

While writing the docs, I assumed as the "average" reader of this documentation someone with no experience with Azure who only wants to implement code signing. Because of this, I decided to add a "minimal viable setup" guide to help people get started, but keep the documentation in there to tell people "Hey, if you need another setup structure, here's what you need to know". In addition, I decided to copy over the descriptions from Microsoft's guides to give more security to readers who may be confused by the wording, and emphasize that especially not all environment variables are required in every scenario.

Let me know what you think and if I should change something!

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: c6bfe05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mmaietta
Copy link
Collaborator

mmaietta commented Feb 6, 2025

This is fantastic, thank you @nathanlesage !

@mmaietta mmaietta merged commit b478202 into electron-userland:master Feb 6, 2025
15 checks passed
@nathanlesage nathanlesage deleted the patch-1 branch February 6, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants