chore(refactor): electron-updater cyclical imports #8913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to prep for migration to rollup + vite (which have much more strict module resolutions)
🦋 Changeset detectedLatest commit: 9652f54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
beyondkmp
reviewed
Feb 27, 2025
beyondkmp
previously approved these changes
Feb 27, 2025
This was referenced Feb 27, 2025
Merged
lyswhut
reviewed
Mar 4, 2025
| @@ -0,0 +1,81 @@ | |||
| import { CancellationToken, PackageFileInfo, ProgressInfo, UpdateFileInfo, UpdateInfo } from "builder-util-runtime" | |||
There was a problem hiding this comment.
Please export ProgressInfo and UpdateInfo in the electron-updater package.
These types of exports have been removed: export { CancellationToken, PackageFileInfo, ProgressInfo, UpdateFileInfo, UpdateInfo }
My app depends on UpdateInfo and ProgressInfo types, and I noticed that this change removed the exports of these two types :(
Collaborator
Author
There was a problem hiding this comment.
Oh no! Sorry about that, I must have missed the re-export. Will get that into the next release asap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring code to reduce cyclical imports in order to migrate to rollup and/or vitest (which have much more strict module resolutions)