Skip to content

fix: stack overflow in electron-builder due to cyclic dependencies in _getNodeModules #9193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DinoscapeProgramming wants to merge 1 commit into from
Closed

fix: stack overflow in electron-builder due to cyclic dependencies in _getNodeModules #9193

DinoscapeProgramming wants to merge 1 commit into from

Conversation

@DinoscapeProgramming
Copy link

@DinoscapeProgramming DinoscapeProgramming commented Jul 5, 2025 •
edited
Loading

This PR fixes a "Maximum call stack size exceeded" error caused by infinite recursion in the _getNodeModules method within NodeModulesCollector.

Root Cause

The function did not account for cyclic dependencies in the hoisted dependency graph, causing unbounded recursion and stack overflows during the build process.

Fix

  • Added cycle detection using a Set<string> to track visited dependencies.
  • Prevents re-processing already-seen dependencies identified by name@version.

Impact

  • Resolves fatal crash during electron-builder packaging in large or monorepo projects.
  • Makes dependency resolution more stable and safe when hoisting is involved.

Originally reported in #8857.

@DinoscapeProgramming
fix: prevent stack overflow in _getNodeModules due to cyclic dependen…
46a5a0c 
…cies

Adds cycle detection using a Set<string> to avoid infinite recursion
when traversing hoisted dependency graphs. Fixes "Maximum call stack
size exceeded" error during electron-builder packaging.
@DinoscapeProgramming DinoscapeProgramming changed the title Fix stack overflow in electron-builder due to cyclic dependencies in _getNodeModules fix: stack overflow in electron-builder due to cyclic dependencies in _getNodeModules Jul 5, 2025
@DinoscapeProgramming
Copy link
Author

DinoscapeProgramming commented Jul 5, 2025

Sorry, didn't see #8864.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

app-builder-lib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DinoscapeProgramming