fix(packager): package spinner isn't defined when asar.unpack is checked

ISSUES CLOSED: #396
electron · Dec 24, 2017 · 435e83d · 435e83d
1 parent 1a1884d
commit 435e83d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/api/package.js b/src/api/package.js
@@ -139,7 +139,6 @@ export default async (providedOptions = {}) => {
  });
  packageOpts.quiet = true;
  if (typeof packageOpts.asar === 'object' && packageOpts.asar.unpack) {
- packagerSpinner.fail();
  throw new Error('electron-compile does not support asar.unpack yet. Please use asar.unpackDir');
  }
 

diff --git a/test/slow/api_spec_slow.js b/test/slow/api_spec_slow.js
@@ -267,6 +267,16 @@ describe(`electron-forge API (with installer=${nodeInstaller})`, () => {
  await fs.remove(path.resolve(dir, 'out'));
  });
 
+ it('throws an error when asar.unpack is set', async () => {
+ let packageJSON = await readPackageJSON(dir);
+ packageJSON.config.forge.electronPackagerConfig.asar = { unpack: 'somedir/**' };
+ await fs.writeJson(path.join(dir, 'package.json'), packageJSON);
+ await expect(forge.package({ dir })).to.eventually.be.rejectedWith(/electron-compile does not support asar\.unpack/);
+ packageJSON = await readPackageJSON(dir);
+ delete packageJSON.config.forge.electronPackagerConfig.asar;
+ await fs.writeJson(path.join(dir, 'package.json'), packageJSON);
+ });
+
  it('can package without errors with native pre-gyp deps installed', async () => {
  await installDeps(dir, ['ref']);
  await forge.package({ dir });