Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws error when using asar option #396

Closed
3 tasks done
okonet opened this issue Dec 23, 2017 · 0 comments
Closed
3 tasks done

Throws error when using asar option #396

okonet opened this issue Dec 23, 2017 · 0 comments

Comments

@okonet
Copy link

okonet commented Dec 23, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

When setting asar as described in the documentation, running package command throws an error.

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.

An unhandled rejection has occurred inside Forge:
Cannot read property 'fail' of undefined
TypeError: Cannot read property 'fail' of undefined
    at /Users/okonet/Projects/codestage/node_modules/electron-forge/dist/api/package.js:259:23

What command line arguments are you passing?

none

What does your config.forge data in package.json look like?

{
      "make_targets": {
        "darwin": ["zip"]
      },
      "electronPackagerConfig": {
        "packageManager": "yarn",
        "icon": "resources/icon",
        "ignore": [".idea", "coverage"],
        "asar": {
          "unpack": "./src/electron/*.applescript",
          "unpackDir": "./src/electron/"
        }
      }
    }

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.

Check out this commit: okonet/codestage@dd44eab and run y package

This is pointing to https://github.com/electron-userland/electron-forge/blob/v4.1.6/src/api/package.js#L142 so it seems packagerSpinner is undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants