Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sandbox helper permission updater #16

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

malept
Copy link
Member

@malept malept commented Mar 8, 2019

Generic version of electron-userland/electron-installer-debian#184 and electron-userland/electron-installer-redhat#112, with tests.

To use, you need to override copyApplication similar to how it was initially done in the referenced PRs, except with less code.

CC: @nornagon

@malept malept requested a review from MarshallOfSound March 8, 2019 06:57
@@ -50,6 +50,9 @@ class ElectronInstaller {
return this.options.src
}

/**
* The directory that the bundled application is copied to, relative to `stagingDir`.
*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nornagon thanks for reminding me that stagingAppDir should be documented.

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #16   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         179    184    +5     
=====================================
+ Hits          179    184    +5
Impacted Files Coverage Δ
src/installer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9cab64...ec7f288. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants