Added Promise version for the storage API #105
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
I've been using this electron package for few weeks and I really needed a better looking syntax, so I've created a wrapper over the actual
electron-json-storage
API.I thought it'll take too much to refactor the entire
storage.js
to replace callbacks with Promises, so I choose the fastest way of doing it.The only downside of this solution is that every time the API will change (new methods, changes to current methods), the
async.js
file will have to be updated too!Usage:
Note: everything works great, but the docs are not updated and there are no tests; consider this PR just a draft.
Let me know what do you think!
Would you merge this as is or would you like to refactor the
storage.js
instead?Regards,
Tanase B.