Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebdriverIO v5 #349

Open
eostrom opened this issue Feb 6, 2019 · 10 comments
Open

WebdriverIO v5 #349

eostrom opened this issue Feb 6, 2019 · 10 comments

Comments

@eostrom
Copy link

eostrom commented Feb 6, 2019

WebdriverIO 5.0 is out. I started modifying Spectron to use it. I didn't get very far, but if anyone else wants to press forward, my work is in https://github.com/eostrom/spectron/tree/webdriverio-5.
@vladimiry
Copy link

vladimiry commented Mar 26, 2019 •
edited
Loading

It would be awesome to get webdriver 5 supported as it comes with significantly improved typescript typings.

@vladimiry vladimiry mentioned this issue May 31, 2019
Closed
@christian-bromann
Copy link

Hey 👋 ,

this is Christian from the WebdriverIO team. Is there any chance I can help with this issue? @eostrom ?

Cheers

@eostrom
Copy link
Author

eostrom commented Jul 2, 2019

Hi @christian-bromann. I've moved on from the project I was using Spectron for, but if you want to pursue the WebdriverIO upgrade you are more than welcome to use the branch above as a starting point. There's just one commit, and it's mostly renaming things... plus it looks like I simplified client initialization using a promise returned from WebDriver.remote.

There may be mistakes, I wasn't able to test thoroughly.

@rebeccadallorso
Copy link

@christian-bromann, if this is an issue that is being picked up and worked on - myself and I know a few others would love to help out as well. This fix would help streamline to have our webpage tests line up with our electron tests, which we would love to see!

@christian-bromann
Copy link

@codebytere is this being planned to get picked up or is community involvement expected?

@codebytere
Copy link
Member

I can try to help but unfortunately the core team does not have the bandwidth to proritize this right now.

@dbjorge dbjorge mentioned this issue Oct 7, 2019
Merged
1 task
dbjorge added a commit to microsoft/accessibility-insights-web that referenced this issue Oct 7, 2019
@dbjorge
chore: exclude webdriverio v5 from dependabot updates (#1378)
c2422ee 
#### Description of changes

We only use the webdriverio package for the sake of getting typings to use with Spectron, so we want to keep its major version pinned to the major version spectron uses (v4) until spectron updates (see electron-userland/spectron#349 )

Verified that the updated file passes the [dependabot config file validator](https://dependabot.com/docs/config-file/validator/).

#### Pull request checklist

- [n/a] Addresses an existing issue: Fixes #0000
- [n/a] Added relevant unit test for your changes. (`yarn test`)
- [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage`
- [x] Ran precheckin (`yarn precheckin`)
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS
@shahidmau
Copy link

Is there any progress on this?

@vladimiry vladimiry mentioned this issue Feb 3, 2020
Open
@mtgto mtgto mentioned this issue Mar 7, 2020
Closed
@s4m0r4m4
Copy link

s4m0r4m4 commented Apr 6, 2020

+1 to this, would love to see spectron upgraded to the latest webdriverio --> v6 just came out a few days ago. https://www.npmjs.com/package/webdriverio

Right now I get npm install warnings since spectron has a dependency chain to an outdated versions of core-js, request, and other packages through webdriverio. I even get a warning about webdriverio being outdated:
npm WARN deprecated webdriverio@4.14.4: outdated version, please use @next

@vladimiry vladimiry mentioned this issue Apr 17, 2020
Open
@smariel
Copy link

smariel commented Apr 19, 2020

It would be very appreciated to move to WebDriverIO v5 or v6 since the v4 website is no longer online anymore. Fortunately, the API page is still available.

For now, adding webdriverOptions: {'deprecationWarnings': false} clears up the tests results.

@mikesbrown mikesbrown mentioned this issue Apr 22, 2020
Closed
@umarcor umarcor mentioned this issue May 5, 2020
Closed
@alexandramedway
Copy link
Contributor

PR is now up for updating to v5:
#631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@eostrom @shahidmau @christian-bromann @vladimiry @codebytere @smariel @alexandramedway @s4m0r4m4 @rebeccadallorso