Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ts config for electron-builder #236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaindrop
Copy link

Description

I noticed that in a recent commit the electron-builder.json5 was changed to electron-builder.json and a JSON schema was included, which is great. Since we are at it, why not just use the .config.ts format, which allows either a config object or a function returning a config object according to https://www.electron.build/configuration.

It aligns well with other configurations like vite.config.ts, provides better IntelliSense than JSON schema, and allows easy future customization if the config shall ever be generated by a function.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant