Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.14.4 broke my build #73

Closed
Stanzilla opened this issue May 22, 2023 · 5 comments
Closed

0.14.4 broke my build #73

Stanzilla opened this issue May 22, 2023 · 5 comments

Comments

@Stanzilla
Copy link

Hey there, I don't know why exactly but the update broke my build, see here https://github.com/WeakAuras/WeakAuras-Companion/actions/runs/5047264176/jobs/9053884886?pr=1891

vite v4.3.8 building for production...
transforming...
✓ 1 modules transformed.
rendering chunks...
computing gzip size...
dist-electron/preload/index.js  1.57 kB │ gzip: 0.76 kB
Binding arguments in strict mode (Note that you need plugins to import files that are not JavaScript)
file: /home/runner/work/WeakAuras-Companion/WeakAuras-Companion/node_modules/.vite-electron-renderer/archiver.mjs:4:13
2: export const length = _M_.length;
3: export const name = _M_.name;
4: export const arguments = _M_.arguments;
                ^
5: export const caller = _M_.caller;
6: export const prototype = _M_.prototype;
error during build:
RollupError: Binding arguments in strict mode (Note that you need plugins to import files that are not JavaScript)
    at error (file:///home/runner/work/WeakAuras-Companion/WeakAuras-Companion/node_modules/rollup/dist/es/shared/node-entry.js:2125:[30](https://github.com/WeakAuras/WeakAuras-Companion/actions/runs/5047264176/jobs/9053884886?pr=1891#step:7:31))
    at Module.error (file:///home/runner/work/WeakAuras-Companion/WeakAuras-Companion/node_modules/rollup/dist/es/shared/node-entry.js:1[34](https://github.com/WeakAuras/WeakAuras-Companion/actions/runs/5047264176/jobs/9053884886?pr=1891#step:7:35)38:16)
    at Module.tryParse (file:///home/runner/work/WeakAuras-Companion/WeakAuras-Companion/node_modules/rollup/dist/es/shared/node-entry.js:14145:25)
    at Module.setSource (file:///home/runner/work/WeakAuras-Companion/WeakAuras-Companion/node_modules/rollup/dist/es/shared/node-entry.js:1[37](https://github.com/WeakAuras/WeakAuras-Companion/actions/runs/5047264176/jobs/9053884886?pr=1891#step:7:38)47:[39](https://github.com/WeakAuras/WeakAuras-Companion/actions/runs/5047264176/jobs/9053884886?pr=1891#step:7:40))
    at ModuleLoader.addModuleSource (file:///home/runner/work/WeakAuras-Companion/WeakAuras-Companion/node_modules/rollup/dist/es/shared/node-entry.js:23712:20)
✓ built in 37ms
Error: Process completed with exit code 1.
@Stanzilla
Copy link
Author

Stanzilla commented May 22, 2023

I also see this when running in dev:

image

which looks like a path issue when testing on Windows

Edit: note this happens also with the older version, I just never tested it in dev mode. it works fine in build.

caoxiemeihao added a commit that referenced this issue May 23, 2023
@caoxiemeihao caoxiemeihao mentioned this issue May 23, 2023
@caoxiemeihao
Copy link
Member

👋 fixed 😂
caoxiemeihao/lib-esm@0cc3de0
46def0c

@Stanzilla
Copy link
Author

Thank you!

@caoxiemeihao
Copy link
Member

caoxiemeihao commented May 23, 2023

Works now? :)

@Stanzilla
Copy link
Author

Yes, looks like it! Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants