Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove broken or deprecated apps #1559

Merged
merged 6 commits into from
Oct 24, 2020
Merged

fix: Remove broken or deprecated apps #1559

merged 6 commits into from
Oct 24, 2020

Conversation

MrOsta
Copy link
Contributor

@MrOsta MrOsta commented Oct 24, 2020

⚠️ Issue Reference #1548

many apps are now broken or no longer working, and thus should be removed from our directories


What did i do?

I just found 5 apps that are using the old versions of electron, or their website link is no longer working,
so i disabled them

Please check my pull request and if you have any feedback please let me know 😄 !

Thanks.

it because the app's website link no longer works
because the electron version is older than 3.x ( "electron": "1.6.14" )
because the electron version is older than 3.x ( "electron": "^2.0.0" )
because the electron version is older than 3.x ( "electron": "^1.8.8" )
because the electron version is older than 3.x ( "electron": "^2.0.10" )
I just added wrong link, and edited this little mistake in this commit
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statuses are exactly as described by @MrOsta. LGTM.

@ckerr ckerr merged commit 86e3d26 into electron:master Oct 24, 2020
@MrOsta
Copy link
Contributor Author

MrOsta commented Oct 24, 2020

@ckerr Thanks, good to hear that 😄 ,
Also can you accept this PR to Hacktoberfest ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants