Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow macOS apps to set activation policies #21983

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Closes #21970.

Right now, we allow users access to some dock functionality by hooking into pretty low-level components, but that can cause bugs as evidenced here, here, and here. For apps that want to set more clear and understandable app activation policies, this new small function on app, setActivationPolicy, should allow them to do that without adding much API maintenance or surface area for bugs.

Alternatives considered:

  • Apps can set the LSUIElement value to indicate that their app is an agent app that runs in the background, but that's not intuitive by comparison

cc @zcbenz @MarshallOfSound @ckerr

Checklist

Release Notes

Notes: Added the ability to set app activation policy on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2020
@codebytere codebytere force-pushed the activation-policy branch 2 times, most recently from 542e6cc to ec4e3c0 Compare January 31, 2020 04:18
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 1, 2020
Copy link
Contributor

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API looks straightforward 👍 .

@codebytere
Copy link
Member Author

codebytere commented Feb 5, 2020

Linux failures are unrelated - see #22033.

@codebytere codebytere merged commit 303ca10 into master Feb 5, 2020
@codebytere codebytere deleted the activation-policy branch February 5, 2020 19:12
@release-clerk
Copy link

release-clerk bot commented Feb 5, 2020

Release Notes Persisted

Added the ability to set app activation policy on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for the ability to control app activation policy on macOS
2 participants