Make copies of the dep lists instead of altering in-place

electron · Jan 9, 2019 · 1709af0 · 1709af0
1 parent a74169e
commit 1709af0
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/api/core/src/util/electron-version.ts b/packages/api/core/src/util/electron-version.ts
@@ -25,17 +25,19 @@ export function getElectronVersion(packageJSON: any) {
 }
 
 export function updateElectronDependency(packageJSON: any, dev: string[], exact: string[]): [string[], string[]] {
+ const alteredDev = ([] as string[]).concat(dev);
+ let alteredExact = ([] as string[]).concat(exact);
  if (Object.keys(packageJSON.devDependencies).find(findElectronDep)) {
- exact = exact.filter(dep => dep !== 'electron');
+ alteredExact = alteredExact.filter(dep => dep !== 'electron');
  } else {
  const electronKey = Object.keys(packageJSON.dependencies).find(findElectronDep);
  if (electronKey) {
- exact = exact.filter(dep => dep !== 'electron');
+ alteredExact = alteredExact.filter(dep => dep !== 'electron');
  d(`Moving ${electronKey} from dependencies to devDependencies`);
- dev.push(`${electronKey}@${packageJSON.dependencies[electronKey]}`);
+ alteredDev.push(`${electronKey}@${packageJSON.dependencies[electronKey]}`);
  delete packageJSON.dependencies[electronKey];
  }
  }
 
- return [dev, exact];
+ return [alteredDev, alteredExact];
 }