disabled -> enabled

electron · Mar 24, 2022 · 2e5ded0 · 2e5ded0
1 parent 9ea965b
commit 2e5ded0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/api/core/src/api/make.ts b/packages/api/core/src/api/make.ts
@@ -118,7 +118,8 @@ export default async ({
  if (!maker.platforms.includes(actualTargetPlatform)) continue;
  } else {
  const resolvableTarget: IForgeResolvableMaker = target as IForgeResolvableMaker;
- if (resolvableTarget.disabled) continue;
+ // non-false falsy values should be 'true'
+ if (resolvableTarget.enabled === false) continue;
 
  if (!resolvableTarget.name) {
  throw new Error(`The following maker config is missing a maker name: ${JSON.stringify(resolvableTarget)}`);

diff --git a/packages/api/core/test/fixture/app-with-maker-disable/package.json b/packages/api/core/test/fixture/app-with-maker-disable/package.json
@@ -5,7 +5,7 @@
  "makers": [
  {
  "name": "@electron-forge/maker-zip",
- "disabled": true,
+ "enabled": false,
  "platforms": [
  "linux"
  ]

diff --git a/packages/utils/types/src/index.ts b/packages/utils/types/src/index.ts
@@ -70,7 +70,7 @@ export interface IForgePlugin {
 }
 
 export interface IForgeResolvableMaker {
- disabled: boolean;
+ enabled: boolean;
  name: string;
  platforms: ForgePlatform[] | null;
  config: any; // eslint-disable-line @typescript-eslint/no-explicit-any