feat(installer): don't suffix temp install files with .forge-install

electron · Dec 31, 2016 · a6f0749 · a6f0749
1 parent e8c83cd
commit a6f0749
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/src/electron-forge-install.js b/src/electron-forge-install.js
@@ -109,7 +109,7 @@ const main = async () => {
 
   const tmpdir = path.resolve(os.tmpdir(), 'forge-install');
   const pathSafeRepo = repo.replace(/\//g, '-').replace(/\\/g, '-');
-  const filename = `${pathSafeRepo}-${latestRelease.tag_name}-${targetAsset.name}.forge-install`;
+  const filename = `${pathSafeRepo}-${latestRelease.tag_name}-${targetAsset.name}`;
 
   const fullFilePath = path.resolve(tmpdir, filename);
   if (!await fs.exists(fullFilePath) || (await fs.stat(fullFilePath)).size !== targetAsset.size) {

diff --git a/src/installers/darwin/dmg.js b/src/installers/darwin/dmg.js
@@ -1,14 +1,5 @@
-import fs from 'fs-promise';
 import opn from 'opn';
-import path from 'path';
-import pify from 'pify';
-import { exec } from 'child_process';
 
 export default async (filePath) => {
-  const DMGPath = path.join(path.dirname(filePath), path.parse(filePath).name);
-  if (await fs.exists(DMGPath)) {
-    await fs.remove(DMGPath);
-  }
-  await pify(exec)(`cp "${filePath}" "${DMGPath}"`);
-  await opn(DMGPath, { wait: false });
+  await opn(filePath, { wait: false });
 };