Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import: if no Electron module is found in existing project, default to latest Electron version #114

Closed
malept opened this issue Jan 31, 2017 · 0 comments
Closed

Import: if no Electron module is found in existing project, default to latest Electron version #114

malept opened this issue Jan 31, 2017 · 0 comments
Assignees
@MarshallOfSound
Labels
enhancement help wanted import in pr

Comments

@malept
Copy link
Member

malept commented Jan 31, 2017

Initially from @anulman in #108:

Our users will rarely have electron pre-installed, which leads to the electron-prebuilt-compile install step being skipped

@MarshallOfSound adds:

Defaulting to latest sounds reasonable if no version of Electron can be found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarshallOfSound MarshallOfSound

Labels
enhancement help wanted import in pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malept @MarshallOfSound