Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Publisher: support different folders for different targets within a single S3 bucket #374

Closed
3 tasks done
paulschneider opened this issue Nov 27, 2017 · 2 comments
Closed
3 tasks done

Comments

@paulschneider
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

Is it possible to have electron-forge distribute to different folders within a single s3 bucket? Currently I believe we can push artefacts to a single bucket and directory.

I am hoping to be able to push into architecture segregated structures as follows:

s3://bucket_name/releases/darwin/...files
s3://bucket_name/releases/win/...files
s3://bucket_name/releases/lunix/...files

Is this currently possible? Or planned?

@MarshallOfSound
Copy link
Member

We could make this possible by adding a keyResolver config option. Might look something like so:

s3: {
  keyResolver: (artifactName, platform, arch) => string
}

Would that kind of thing work for your use case?

@paulschneider
Copy link
Author

Thats much cleaner that what I was thinking but yes, perfect.

@malept malept changed the title Feature request - specific s3 targets S3 Publisher: support different folders for different targets within a single S3 bucket Nov 27, 2017
MarshallOfSound added a commit that referenced this issue Apr 16, 2018
MarshallOfSound added a commit that referenced this issue Apr 16, 2018
MarshallOfSound added a commit that referenced this issue Apr 17, 2018
dsanders11 pushed a commit that referenced this issue Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants