Skip to content

Regression in v7.8.1: index.html no longer listed in Webpack assets #3949

@nikwen

Description

@nikwen

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Forge version

7.8.1

Electron version

36.4.0

Operating system

Windows 10 (19045.5854)

Last known working Forge version

7.8.0

Expected behavior

Webpack plugins see my renderer's index.html as an asset when calling compilation.getAssets().

Actual behavior

Starting with Forge v7.8.1, Webpack plugins do not see my renderer's index.html as an asset when calling compilation.getAssets() on Windows. (It works fine on macOS.)

This broke the build script of my app.

Steps to reproduce

  1. Clone https://github.com/nikwen/forge-jiti-bug
    • This repo consists of two commits:
      1. 507f56c: The unchanged output of npx create-electron-app@latest forge-jiti-bug --template=webpack-typescript (with Forge v7.8.1)
      2. 83fb84f: Adding a minimal Webpack plugin that logs the result of compilation.getAssets()
  2. npm install
  3. npm start
  4. The output is:
    main_window/preload.js
    main_window/index.js
    
    (This is the list of assets that Webpack plugins see on Forge v7.8.1.)
  5. git checkout forge-v7.8.0
    • This branch has one additional commit d5ef061: Downgrading Forge to v7.8.0
  6. npm install
  7. npm start
  8. The output is:
    main_window/preload.js
    main_window/index.js
    main_window/index.html
    
    (This is the expected behavior — the list of assets that Webpack plugins see on Forge v7.8.0.)

Additional information

  1. This works fine on macOS.
  2. This was introduced by fix(core): load TypeScript configurations with jiti #3907 (the jiti PR).
  3. It broke the build script of my app.
  4. Workaround: renaming forge.config.ts to forge.config.tsx (because jiti isn't used for .tsx files)

Metadata

Metadata

Assignees

Labels

bugplatform/windowsplugin/webpackIssues or pull requests related to first-party webpack plugins/templates

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions