-
-
Notifications
You must be signed in to change notification settings - Fork 609
Open
Labels
bugplatform/windowsplugin/webpackIssues or pull requests related to first-party webpack plugins/templatesIssues or pull requests related to first-party webpack plugins/templates
Description
Pre-flight checklist
- I have read the contribution documentation for this project.
- I agree to follow the code of conduct that this project uses.
- I have searched the issue tracker for a bug that matches the one I want to file, without success.
Forge version
7.8.1
Electron version
36.4.0
Operating system
Windows 10 (19045.5854)
Last known working Forge version
7.8.0
Expected behavior
Webpack plugins see my renderer's index.html as an asset when calling compilation.getAssets().
Actual behavior
Starting with Forge v7.8.1, Webpack plugins do not see my renderer's index.html as an asset when calling compilation.getAssets() on Windows. (It works fine on macOS.)
This broke the build script of my app.
Steps to reproduce
- Clone https://github.com/nikwen/forge-jiti-bug
npm installnpm start- The output is:
(This is the list of assets that Webpack plugins see on Forge v7.8.1.)
main_window/preload.js main_window/index.js git checkout forge-v7.8.0- This branch has one additional commit d5ef061: Downgrading Forge to v7.8.0
npm installnpm start- The output is:
(This is the expected behavior — the list of assets that Webpack plugins see on Forge v7.8.0.)
main_window/preload.js main_window/index.js main_window/index.html
Additional information
- This works fine on macOS.
- This was introduced by fix(core): load TypeScript configurations with
jiti#3907 (thejitiPR). - It broke the build script of my app.
- Workaround: renaming
forge.config.tstoforge.config.tsx(becausejitiisn't used for.tsxfiles)
Metadata
Metadata
Assignees
Labels
bugplatform/windowsplugin/webpackIssues or pull requests related to first-party webpack plugins/templatesIssues or pull requests related to first-party webpack plugins/templates