-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows installer create shortcut - question #489
Comments
This isn't an issue with |
@cballantyne Did you ever get this issue solved? Looking at this comment: electron/electron#8862 (comment) prompted us to update our code:
And we updated to:
The issue got resolved doing this, but the shortcut is now not created. |
@GitFlip - no. I just gave up in the end. Burned too much time on it. |
Our mistake, |
I can confirm, changing: if ( require( "electron-squirrel-startup" ) ) app.quit(); to: if ( require( "electron-squirrel-startup" ) ) app.exit(); and the issue went away. |
Please describe your issue:
I am stumped on trying to get the installer created using electron-forge make to create the windows shortcuts. Can I please verify I should just be adding the following to my main.js:
if(require('electron-squirrel-startup')) app.quit();
I have seen another couple of older issues where config for win32metadata was added under electronPackagerConfig in package.json. This doesn't seem to make a difference.
I am getting a javascript error when running the installer. I cannot copy the text from the alert so have attached snippet.
![screenshot1](https://user-images.githubusercontent.com/3897499/38930560-ac04628a-4353-11e8-8c1e-4bc75728c150.PNG)
I am sorry if this is not the right place. I can see electron-forge uses windows-installer which in turn uses electron-squirrel-startup. electron-squirrel-startup seems dead. I can close and move this to appropriate place if needed.
Console output when you run
electron-forge
with the environment variableDEBUG=electron-forge:*
. (Instructions on how to do so here). Please include the stack trace if one exists.What command line arguments are you passing?
What does your
config.forge
data inpackage.json
look like?Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using
electron-forge init
is a good starting point, if that is not thesource of your problem.
The text was updated successfully, but these errors were encountered: