Signed applications are "invalid" on macOS

[MarshallOfSound]

Traced this to be due to the packager signing and then we modify the ASAR file. Should extract the signing config and sign ourselves.

/cc @malept

[malept]

I think a better way is to use a packager hook (one that exists or make a new one) to run electron-compile, and then have Electron Packager run as normal. Is that feasible?

[MarshallOfSound]

@malept The issue is the ASAR file AFAIK. The problem is we must compile in the packaged folder (or we will generate a cache in the development directory). So if we need to generate a cache and the user has generated an ASAR then we can't generate a cache.

So we remove the ASAR request and do it manually afterwords.

[malept]

Sorry if I'm being rather dense about this, but it's not clear to me why the electron-compile step can't work similarly to your proposed electron-rebuild hook.

[MarshallOfSound]

@malept Hahahahahaha, how did I miss that 😆

It can almost certainly be done there 👍