Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template CSS into a separate file #1010

Merged
merged 4 commits into from
Jul 12, 2019
Merged

Move template CSS into a separate file #1010

merged 4 commits into from
Jul 12, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jul 11, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Due to the change, we also need to add style-loader/file-loader plus the appropriate import magic to the renderer.

Fixes #941.

Co-Authored-By: Samuel Attard <sattard@slack-corp.com>
@malept malept merged commit fe33a73 into master Jul 12, 2019
@malept malept deleted the template-separate-css branch July 12, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update webpack template to include an example of using static assets
2 participants