fix(maker): allow most appx default config to be overridden by the user #121
Conversation
|
Nah, I'd allow them to override pretty much anything. |
|
Ugh, need to fix test fixtures before merging. I'll do that when I get home (if no one else beats me to it). |
malept
force-pushed
the
appx-params-order
branch
2 times, most recently
from
85c5bd4 to
6b493ae
Compare
|
OK, I've expended enough brain cells trying to fix this tonight. Maybe someone else wants a go? 😄 |
test/slow/api_spec_slow.js
Outdated
| @@ -152,6 +152,12 @@ describe(`electron-forge API (with installer=${installer.substr(12)})`, () => { | |||
| dir = path.resolve(os.tmpdir(), `electron-forge-test-${dirID}/electron-forge-test`); | |||
| dirID += 1; | |||
| await forge.init({ dir }); | |||
|
|
|||
| const packageJSON = await readPackageJSON(dir); | |||
| packageJSON.name = 'testApp'; | |||
There was a problem hiding this comment.
This is not a valid app name (could be causing the issues) has be all lower case
There was a problem hiding this comment.
Here's the error in question:
MakeAppx : error: Error info: error C00CE169: App manifest validation error: The app manifest must be valid as per schema: Line 6, Column 13, Reason: '' violates minLength constraint of '3'.
The attribute 'Name' with value '' failed to parse.
MakeAppx : error: Package creation failed.
MakeAppx : error: 0x80080204 - The specified package format is not valid: The package manifest is not valid.
How I read that was that it failed because the app name was blank for some reason. But I haven't actually used appx packaging before 😰
malept
force-pushed
the
appx-params-order
branch
4 times, most recently
from
626762b to
51b3a5b
Compare
|
I am very confused as to why I'm getting errors for Squirrel now: https://ci.appveyor.com/project/electron-userland/electron-forge/build/1.0.266#L7942 |
|
@malept Looking into it now on my windows machine 👍 |
|
@malept I fixed this locally, but now I can't remember what I did to fix it.... Will check my laptop tonight 😆 |
malept
force-pushed
the
appx-params-order
branch
from
0c053bb to
78dae56
Compare
Working around bug in electron-installer-redhat (see: electron-userland/electron-installer-redhat#45).
malept
force-pushed
the
appx-params-order
branch
from
78dae56 to
5484c2b
Compare
This PR adds a new make type for Windows, "appx", which generates Windows Store packages ISSUES CLOSED: #27
|
@MarshallOfSound when you have time, please go grab that fix 😄 |
|
Jesus I keep not doing this... 😆 |
MarshallOfSound
force-pushed
the
appx-params-order
branch
from
f20116d to
3605d0c
Compare
|
Yay, tests finally pass 🎉 🙌 |
ISSUES CLOSED: #119
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Are your changes appropriately documented?
Yes (arguably the docs did not match the code)
Do your changes have sufficient test coverage?
Yes
Does the testsuite pass successfully on your local machine?
Yes
Summarize your changes:
Allow users to override most of the default electron-windows-store config set by Forge.
Fixes #119.
@felixrieseberg are there any of the default params aside from
inputDirectoryandoutputDirectorythat we do not want the user to override? FOr instance, perhapspackageExecutable?