Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add template for typescript #1319

Merged
merged 7 commits into from
Dec 4, 2019
Merged

feat: add template for typescript #1319

merged 7 commits into from
Dec 4, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Dec 3, 2019

Adds a custom templater for TypeScript:

npx create-electron-app my-new-app --template=typescript.

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

@codebytere codebytere force-pushed the typescript-template branch 2 times, most recently from 33a9564 to 3db8420 Compare December 4, 2019 05:44
@codebytere codebytere marked this pull request as ready for review December 4, 2019 05:44
@codebytere codebytere changed the title [WIP] feat: add template for typescript feat: add template for typescript Dec 4, 2019
@codebytere codebytere force-pushed the typescript-template branch 2 times, most recently from 34bab34 to 98d7b12 Compare December 4, 2019 05:51
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy to see another built-in template!

packages/api/core/test/slow/api_spec_slow.ts Outdated Show resolved Hide resolved
packages/api/core/test/slow/api_spec_slow.ts Outdated Show resolved Hide resolved
packages/template/typescript/src/TypeScriptTemplate.ts Outdated Show resolved Hide resolved
packages/template/typescript/src/TypeScriptTemplate.ts Outdated Show resolved Hide resolved
packages/template/typescript/src/TypeScriptTemplate.ts Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the typescript-template branch 2 times, most recently from 3ce6506 to c4abe7a Compare December 4, 2019 16:22
@codebytere codebytere force-pushed the typescript-template branch 2 times, most recently from 60a223a to 907e37e Compare December 4, 2019 17:15
@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #1319 into master will increase coverage by 24.84%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1319       +/-   ##
===========================================
+ Coverage   41.53%   66.37%   +24.84%     
===========================================
  Files           4       70       +66     
  Lines         183     2040     +1857     
  Branches       37      383      +346     
===========================================
+ Hits           76     1354     +1278     
- Misses         95      535      +440     
- Partials       12      151      +139
Impacted Files Coverage Δ
...ages/template/typescript/src/TypeScriptTemplate.ts 100% <100%> (ø)
packages/maker/snap/src/MakerSnap.ts 100% <0%> (ø)
...es/api/core/src/api/init-scripts/init-directory.ts 93.75% <0%> (ø)
packages/api/core/src/util/index.ts 100% <0%> (ø)
packages/api/core/src/util/publish-state.ts 85.36% <0%> (ø)
packages/utils/async-ora/src/index.ts 100% <0%> (ø)
packages/maker/wix/src/util/author-name.ts 80% <0%> (ø)
packages/plugin/webpack/src/WebpackPlugin.ts 30.41% <0%> (ø)
packages/maker/rpm/src/MakerRpm.ts 94.73% <0%> (ø)
packages/installer/base/src/Installer.ts 75% <0%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d337355...09c2858. Read the comment docs.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@malept
Copy link
Member

malept commented Dec 4, 2019

We'll need to add a page to the electronforge.io docs before we make a new beta release.

@malept malept merged commit cece7da into master Dec 4, 2019
@malept malept deleted the typescript-template branch December 4, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants