Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate lodash dependencies #1464

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

malept
Copy link
Member

@malept malept commented Feb 3, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Lowers the number of direct dependencies for Forge.

@malept malept force-pushed the consolidate-lodash-deps branch 2 times, most recently from f02fcec to 10b48c7 Compare February 3, 2020 02:46
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #1464 into master will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1464   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files          73       73           
  Lines        2130     2130           
  Branches      397      397           
=======================================
  Hits         1601     1601           
  Misses        405      405           
  Partials      124      124
Impacted Files Coverage Δ
packages/publisher/github/src/util/github.ts 100% <100%> (ø) ⬆️
packages/api/core/src/util/forge-config.ts 80.3% <100%> (ø) ⬆️
packages/api/core/src/api/import.ts 56.86% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11fdaa...338d4f6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant