fix(publisher-electron-release-server): throw an exception for 4xx/5xx HTTP status codes

[pierrickouw]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

node-fetch doesn't fail when a 4xx is raised (https://www.npmjs.com/package/node-fetch#handling-client-and-server-errors).

Our release process rely on this to make sure the files are properly updated during a electron-forge publish, but sometimes the Electron Release Server might send 4xx or 5xx errors and we are fooled into thinking "everything is ok" 🙂

Do not hesitate if you need more information !

[malept]

Thanks for the pull request! This seems like a good change, conceptually. I've made a couple of comments about the implementation.

It would be nice to have a regression test for this. Could you add one using the fetch-mock module?

[pierrickouw]

@malept thanks for your feedbacks! I added one test and implemented your suggestion.

[malept]

Thanks for writing the test! I'm concerned that the test doesn't test the change you've made. I've made more detailed comments below.

[malept]

Looks good! Thanks for working with me on the changes.