Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): overrideTargets inherit the named maker config in the Forge config #1549

Merged
merged 4 commits into from
Mar 7, 2020

Conversation

malept
Copy link
Member

@malept malept commented Mar 4, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This should fix #1083.

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #1549 into master will increase coverage by 0.04%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1549      +/-   ##
==========================================
+ Coverage   73.52%   73.57%   +0.04%     
==========================================
  Files          74       74              
  Lines        2187     2191       +4     
  Branches      410      412       +2     
==========================================
+ Hits         1608     1612       +4     
- Misses        453      454       +1     
+ Partials      126      125       -1     
Impacted Files Coverage Δ
packages/maker/base/src/Maker.ts 72.97% <0.00%> (ø)
packages/api/core/src/util/rebuild.ts 92.85% <0.00%> (ø)
packages/api/core/src/util/resolve-dir.ts 76.66% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da229e8...e9bc6ad. Read the comment docs.

@malept malept force-pushed the make-override-targets-inherit-config branch from eac2f25 to c0e2939 Compare March 4, 2020 23:08
@malept malept marked this pull request as ready for review March 7, 2020 00:16
@malept malept force-pushed the make-override-targets-inherit-config branch from 942ffe7 to 0c6fbda Compare March 7, 2020 00:41
@malept malept force-pushed the make-override-targets-inherit-config branch from 0c6fbda to ebef6aa Compare March 7, 2020 01:42
@malept malept merged commit e133b60 into master Mar 7, 2020
@malept malept deleted the make-override-targets-inherit-config branch March 7, 2020 02:34
@jpalumickas
Copy link

@malept Thanks for this fix! 🙂
Maybe you know when the next release will be made with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maker config not used when specifying target
2 participants