Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): add options to allow use custom instance #1601

Merged
merged 2 commits into from
Mar 31, 2020
Merged

feat(s3): add options to allow use custom instance #1601

merged 2 commits into from
Mar 31, 2020

Conversation

vhashimotoo
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR adds the endpoint option what's adds the ability to change default S3 endpoint, to custom S3 instance. Also added s3ForcePathStyle and region for the same reasons.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one question.

packages/publisher/s3/src/PublisherS3.ts Outdated Show resolved Hide resolved
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
@malept malept merged commit 38e63d1 into electron:master Mar 31, 2020
@masterkain
Copy link

thanks, I just started out and trying to use scaleway's object storage, any chance we can cut a 6.0.0-beta.51 release with this in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants