-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maker-pkg): allow to override .pkg name #1785
Conversation
@malept could you please have a look at this PR |
@malept What should I do to have this PR merged? |
Codecov Report
@@ Coverage Diff @@
## master #1785 +/- ##
===========================================
+ Coverage 60.28% 72.71% +12.42%
===========================================
Files 71 74 +3
Lines 2153 2221 +68
Branches 411 421 +10
===========================================
+ Hits 1298 1615 +317
+ Misses 676 446 -230
+ Partials 179 160 -19
Continue to review full report at Codecov.
|
@malept PR has been updated on latest master. |
@malept ping |
@malept ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! I'm sorry to review the code only now. 🙇♂️
Looks great, just needs some minor improvements.
Done! I'm looking forward to have it merged. |
Hey @mahnunchik CI failed. Can you execute |
All done! |
@mahnunchik This PR has a conflict because #3057 was merged, can you fix it? 🙇♂️ |
ISSUES CLOSED: electron#1784
Co-authored-by: Black-Hole <158blackhole@gmail.com>
@BlackHole1 what is wrong with CI tests? I've rebased PR on current main. |
Test case need modify and should be a simple. |
@BlackHole1 mistypo while rebase has been fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @erickzhao
I'm looking forward to have this PR merged 😉 |
ISSUES CLOSED: #1784
Summarize your changes:
Allow to override
.pkg
filename.