fix(rebuilder): rebuild modules inside @ scoped folders as well #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nope, would be "easy" enough to make one though if necessary. |
|
I'm gonna merge this in so it isn't left handing while I refactor the rebuilding logic |
|
If you don't mind, I'm going to add an issue to add a test for this. |
|
Yup, I'll be adding quite a few tests to the new rebuilding logic 👍 |
dsanders11
pushed a commit
that referenced
this pull request
Jan 14, 2023
Graceful opening, central IPC, cleaner menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Are your changes appropriately documented?
N/A
Do your changes have sufficient test coverage?
Not really, @malept do you know any native modules that are scoped.
Does the testsuite pass successfully on your local machine?
Yes
Summarize your changes:
Fix rebuilding scoped modules