fix(packager): throw error when electron-prebuilt-compile is not found #2
Conversation
|
Good call 👍 Brings up an interesting point though, how hard is it to take an existing project and make Maybe adding an |
| if (!/[0-9]/.test(packageJSON.devDependencies['electron-prebuilt-compile'][0])) { | ||
| global._resolveError = () => console.error('You must depend on an EXACT version of "electron-prebuilt-compile" not a range'.red); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
I think this else is at the wrong level (hence the test failure). I think it should be on the nested if statement. And both branches of that nested if statement need to return null
There was a problem hiding this comment.
Oops. That was because I resolved a merge conflict incorrectly. I was wondering why the tests failed.
There was a problem hiding this comment.
I thought I had flaky tests already and was about to cry 😆 Quite happy that it caught it 👍
malept
force-pushed
the
add-prebuilt-compile-error-msg
branch
from
c5090e9
to
d320d9e
Compare
👍 Sounds like something that should be an interactive experience (yeoman-style, I guess) by default. |
|
I'm going to merge this as it is a flaw in the test 👍 |
Mostly useful for existing Electron projects that want to migrate to Electron Forge.