Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add platform and arch to generateAssets hook parameters #2327

Merged
merged 2 commits into from
Jul 11, 2021

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Jun 15, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

This adds platform and arch parameters to the generateAssets hook so it can be used to generate or copy native assets.

{
  hooks: {
    generateAssets: async (config: ForgeConfig, platform: string, arch: string) => {
      console.log('We should generate some assets here');
    }
  }
}

packages/api/core/src/api/start.ts Outdated Show resolved Hide resolved
@malept malept changed the title Add platform and arch to generateAssets hook parameters feat(core): add platform and arch to generateAssets hook parameters Jul 11, 2021
@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #2327 (f6ef2bd) into master (bcb8894) will decrease coverage by 2.43%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
- Coverage   75.54%   73.11%   -2.44%     
==========================================
  Files          74       74              
  Lines        2200     2198       -2     
  Branches      413      415       +2     
==========================================
- Hits         1662     1607      -55     
+ Misses        422      418       -4     
- Partials      116      173      +57     
Impacted Files Coverage Δ
packages/api/core/src/api/start.ts 65.43% <33.33%> (-21.91%) ⬇️
packages/api/core/src/api/package.ts 74.73% <100.00%> (ø)
packages/api/core/src/api/publish.ts 69.73% <0.00%> (-22.37%) ⬇️
packages/api/core/src/api/install.ts 78.20% <0.00%> (-16.67%) ⬇️
packages/api/core/src/api/make.ts 81.72% <0.00%> (-6.58%) ⬇️
packages/api/core/src/api/init.ts 91.17% <0.00%> (-5.89%) ⬇️
packages/api/core/src/util/rebuild.ts 92.85% <0.00%> (ø)
packages/api/core/src/util/upgrade-forge-config.ts 96.42% <0.00%> (+1.69%) ⬆️
packages/installer/darwin/src/InstallerDarwin.ts 33.33% <0.00%> (+1.75%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb8894...f6ef2bd. Read the comment docs.

@malept malept merged commit e3af089 into electron:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants