Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use custom eslint config + prettier instead of airbnb config #2520

Merged
merged 15 commits into from
Sep 12, 2021

Conversation

malept
Copy link
Member

@malept malept commented Sep 12, 2021

Summarize your changes:

Switch from the airbnb eslint config to one that should be more in line with the rest of the Electron tooling that doesn't use StandardJS.

Please note that prettier is configured to use single quotes instead of double quotes. This is mostly because I didn't want an even larger diff.

Added some test scripts to individual modules to run tests in isolation.

While fixing TypeScript types, I fixed a bug in the Forge 5 ➡️ Forge 6 upgrader that used the wrong key name for make targets.

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #2520 (da6a0dc) into master (bc0ed95) will decrease coverage by 0.18%.
The diff coverage is 65.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2520      +/-   ##
==========================================
- Coverage   72.89%   72.71%   -0.19%     
==========================================
  Files          91       91              
  Lines        2365     2349      -16     
  Branches      448      429      -19     
==========================================
- Hits         1724     1708      -16     
  Misses        471      471              
  Partials      170      170              
Impacted Files Coverage Δ
packages/api/cli/src/electron-forge.ts 58.06% <0.00%> (ø)
...ges/api/core/src/api/init-scripts/find-template.ts 95.23% <ø> (ø)
...es/api/core/src/api/init-scripts/init-directory.ts 93.75% <0.00%> (ø)
packages/api/core/src/api/lint.ts 66.66% <0.00%> (-2.57%) ⬇️
packages/api/core/src/util/plugin-interface.ts 31.11% <ø> (ø)
packages/api/core/src/util/require-search.ts 85.71% <0.00%> (ø)
packages/installer/base/src/Installer.ts 75.00% <ø> (ø)
packages/installer/darwin/src/InstallerDarwin.ts 33.33% <0.00%> (ø)
packages/installer/deb/src/InstallerDeb.ts 33.33% <ø> (ø)
packages/installer/dmg/src/InstallerDMG.ts 25.00% <0.00%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0ed95...da6a0dc. Read the comment docs.

@malept malept merged commit 0deb74b into master Sep 12, 2021
@malept malept deleted the malept/chore/eslint-config branch September 12, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant