Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade Node.js to 14 LTS #2921

Merged
merged 1 commit into from
Jul 21, 2022
Merged

feat!: upgrade Node.js to 14 LTS #2921

merged 1 commit into from
Jul 21, 2022

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Jul 20, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

This PR upgrades the Node version used in CI from 12 to 14.
If this upgrade goes smoothly, it may also be worth adding a CI set to test Node 16 (and eventually Node 18 when LTS starts in October).

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #2921 (ac836a2) into master (18156d8) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2921      +/-   ##
==========================================
+ Coverage   71.61%   71.69%   +0.08%     
==========================================
  Files          79       79              
  Lines        2392     2392              
  Branches      450      450              
==========================================
+ Hits         1713     1715       +2     
  Misses        454      454              
+ Partials      225      223       -2     
Impacted Files Coverage Δ
packages/maker/appx/src/MakerAppX.ts 60.71% <0.00%> (+1.78%) ⬆️
packages/api/cli/src/util/check-system.ts 70.73% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18156d8...ac836a2. Read the comment docs.

@VerteDinde VerteDinde requested review from clavin, erickzhao and malept and removed request for clavin and erickzhao July 21, 2022 18:34
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes => LGTM

@malept malept changed the title build: upgrade node to 14 LTS feat!: upgrade Node.js to 14 LTS Jul 21, 2022
@malept malept merged commit 4dcca1c into master Jul 21, 2022
@malept malept deleted the upgrade-node branch July 21, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants