Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update @electron/get to 2.0.0 #2924

Merged
merged 1 commit into from
Aug 23, 2022
Merged

build: update @electron/get to 2.0.0 #2924

merged 1 commit into from
Aug 23, 2022

Conversation

VerteDinde
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Bumps @electron/get to 2.0.0. This is not marked as a breaking change, because the required version of Node for Forge is currently 14+ (@electron/get's new version requires at least 12+)

@VerteDinde VerteDinde changed the title bump: update got to 2.0.0 build: update got to 2.0.0 Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2924 (e386f71) into master (4f79132) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2924      +/-   ##
==========================================
- Coverage   71.43%   71.31%   -0.13%     
==========================================
  Files          79       79              
  Lines        2412     2412              
  Branches      450      452       +2     
==========================================
- Hits         1723     1720       -3     
- Misses        466      469       +3     
  Partials      223      223              
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 38.00% <0.00%> (-0.58%) ⬇️
packages/plugin/webpack/src/WebpackConfig.ts 98.71% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f79132...e386f71. Read the comment docs.

@VerteDinde VerteDinde changed the title build: update got to 2.0.0 build: update @electron/get to 2.0.0 Aug 11, 2022
@VerteDinde VerteDinde merged commit 23eebf1 into master Aug 23, 2022
@VerteDinde VerteDinde deleted the bump-e-get branch August 23, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants