Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): better webpack-dev-server types #2952

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

erickzhao
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Knocks off a TODO item.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #2952 (b9e6b43) into main (d5cf1f2) will increase coverage by 1.28%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2952      +/-   ##
==========================================
+ Coverage   70.04%   71.33%   +1.28%     
==========================================
  Files          79       79              
  Lines        2414     2414              
  Branches      452      452              
==========================================
+ Hits         1691     1722      +31     
+ Misses        507      469      -38     
- Partials      216      223       +7     
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 38.00% <66.66%> (ø)
packages/maker/base/src/Maker.ts 69.69% <0.00%> (+3.03%) ⬆️
packages/api/core/src/api/lint.ts 65.21% <0.00%> (+4.34%) ⬆️
packages/maker/appx/src/MakerAppX.ts 60.34% <0.00%> (+17.24%) ⬆️
packages/maker/wix/src/MakerWix.ts 81.81% <0.00%> (+40.90%) ⬆️
packages/maker/squirrel/src/MakerSquirrel.ts 76.19% <0.00%> (+47.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cf1f2...b9e6b43. Read the comment docs.

@erickzhao erickzhao marked this pull request as ready for review October 12, 2022 07:37
@erickzhao erickzhao merged commit 6c0c222 into main Oct 12, 2022
@erickzhao erickzhao deleted the webpack-dev-server-4 branch October 12, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants