Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade electron-packager@17 #2978

Merged
merged 2 commits into from
Oct 24, 2022
Merged

feat!: upgrade electron-packager@17 #2978

merged 2 commits into from
Oct 24, 2022

Conversation

erickzhao
Copy link
Member

This PR upgrades our usage of Electron Packager to v17. The biggest change here is that we end up using @electron/osx-sign rather than electron-osx-sign.

Should be accompanied with a docs change as well.

@erickzhao erickzhao requested a review from a team October 20, 2022 18:57
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #2978 (3e9c5ab) into main (a8b9dfc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2978   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files          66       66           
  Lines        2144     2144           
  Branches      423      423           
=======================================
  Hits         1582     1582           
+ Misses        359      357    -2     
- Partials      203      205    +2     
Impacted Files Coverage Δ
packages/api/core/src/api/import.ts 61.76% <ø> (ø)
packages/maker/deb/src/MakerDeb.ts 90.90% <0.00%> (ø)
packages/maker/rpm/src/MakerRpm.ts 90.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b9dfc...3e9c5ab. Read the comment docs.

@VerteDinde VerteDinde merged commit 629872d into main Oct 24, 2022
@VerteDinde VerteDinde deleted the packager-17 branch October 24, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants